Auto add CICD label when PR author is a member or owner of flutter organization#4997
Auto add CICD label when PR author is a member or owner of flutter organization#4997gmackall wants to merge 11 commits intoflutter:mainfrom
Conversation
| /// `OWNER` indicate the PR author belongs to the organization. | ||
| static bool _isOrgMember(PullRequest pr) { | ||
| final association = pr.authorAssociation; | ||
| return association == 'MEMBER' || association == 'OWNER'; |
There was a problem hiding this comment.
Are any of these valid:
COLLABORATOR, CONTRIBUTOR, FIRST_TIMER, FIRST_TIME_CONTRIBUTOR, MANNEQUIN, MEMBER, NONE, OWNER
I'm not sure what COLLABORATOR vs CONTRIBUTOR
There was a problem hiding this comment.
I think we want MEMBER or OWNER only here, as that maps to the flutter hackers group, as I understand
|
I can get some |
| await _addCICDForRollers(pullRequestEvent); | ||
| if (pullRequestEvent.changes != null && | ||
| pullRequestEvent.changes!.base != null) { | ||
| await _addCICDForRollersAndMembers(pullRequestEvent); |
There was a problem hiding this comment.
This is a slight behavior change, I made it this way because before the path for scheduling tests checked these conditions:
363e9cd#diff-4d5f5e21f5b7eda8e7775b9a678fb60bb6cfba3321799948fb2b9a55cefbe439L202-L206
And I figured that that was also true for the roller case, so it was hopefully fine to apply to the roller in addition to the member case. Let me know if not
gmackall
changed the title
gmackall
changed the title
3 participants
Fixes flutter/flutter#183618